feat(axis): Expose innerRef prop on the various Axis components #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SheaJanke
changed the title
|
@williaster if you have some time can you have a look at this please? It's a pretty simple change. |
williaster
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Hey @SheaJanke sorry I was on vacation for a couple of weeks and am just catching up. This lgtm! As always, thank you for the contribution 🙌
| @@ -215,4 +216,15 @@ describe('<Axis />', () => { | |||
| expect(points.at(2).prop('from')).toEqual({ x: 10.5, y: 0 }); | |||
| expect(points.at(2).prop('to')).toEqual({ x: 0.5, y: 0 }); | |||
| }); | |||
|
|
|||
| test('should expose its ref via an innerRef prop', () => { | |||
There was a problem hiding this comment.
thank you very much for adding tests 🙏 💯
|
🎉 This PR is included in version |
Onxi95
pushed a commit
to Onxi95/visx
that referenced
this pull request
Nov 21, 2023
…nb#1749) * feat(axis): Expose innerRef prop on the Axis component * feat(axis): Improve documentation for the innerRef prop * feat(axis): Remove unnecessary import * feat(axis): Retrigger build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
Axiscomponents. This makes it possible to get the dimensions of the of theAxiswithout usinggetStringWidthon all the tick values.closes: #1086